7mEZ1v1vnq8TZLW55VI892 changeset

Changeset333063613038 (b)
ParentNone (a)
ab
0+diff --git a/src/couchdb/couch_httpd_rewrite.erl b/src/couchdb/couch_httpd_rewrite.erl
0+index 6324631..ce44fdd 100644
0+--- a/src/couchdb/couch_httpd_rewrite.erl
0++++ b/src/couchdb/couch_httpd_rewrite.erl
0+@@ -126,8 +126,7 @@ handle_rewrite_req(#httpd{
0+     % we are in a design handler
0+     DesignId = <<"_design/", DesignName/binary>>,
0+     Prefix = <<"/", DbName/binary, "/", DesignId/binary>>,
0+-    QueryList = couch_httpd:qs(Req),
0+-    QueryList1 = [{to_binding(K), V} || {K, V} <- QueryList],
0++    QueryList = lists:map(fun decode_query_value/1, couch_httpd:qs(Req)),
0+ 
0+     #doc{body={Props}} = DDoc,
0+ 
0+@@ -145,7 +144,7 @@ handle_rewrite_req(#httpd{
0+ 
0+             %% get raw path by matching url to a rule.
0+             RawPath = case try_bind_path(DispatchList, couch_util:to_binary(Method), PathParts,
0+-                                    QueryList1) of
0++                                    QueryList) of
0+                 no_dispatch_path ->
0+                     throw(not_found);
0+                 {NewPathParts, Bindings} ->
0+@@ -153,13 +152,15 @@ handle_rewrite_req(#httpd{
0+ 
0+                     % build new path, reencode query args, eventually convert
0+                     % them to json
0+-                    Path = lists:append(
0+-                        string:join(Parts, [?SEPARATOR]),
0+-                        case Bindings of
0+-                            [] -> [];
0+-                            _ -> [$?, encode_query(Bindings)]
0+-                        end),
0+-                   
0++                    Bindings1 = maybe_encode_bindings(Bindings),
0++                    ?LOG_INFO("bindings1 ~p~n", [Bindings1]),
0++                    Path = binary_to_list(
0++                        iolist_to_binary([
0++                                string:join(Parts, [?SEPARATOR]),
0++                                [["?", mochiweb_util:urlencode(Bindings1)]
0++                                    || Bindings1 =/= [] ]
0++                            ])),
0++
0+                     % if path is relative detect it and rewrite path
0+                     case mochiweb_util:safe_relative_path(Path) of
0+                         undefined ->
0+@@ -253,44 +254,29 @@ make_query_list([{Key, Value}|Rest], Bindings, Acc) when is_list(Value) ->
0+ make_query_list([{Key, Value}|Rest], Bindings, Acc) ->
0+     make_query_list(Rest, Bindings, [{to_binding(Key), Value}|Acc]).
0+ 
0+-replace_var(Key, Value, Bindings) ->
0+-    case Value of
0+-        <<":", Var/binary>> ->
0+-            get_var(Var, Bindings, Value);
0+-        <<"*">> ->
0+-            get_var(Value, Bindings, Value);
0+-        _ when is_list(Value) ->
0+-            Value1 = lists:foldr(fun(V, Acc) ->
0+-                V1 = case V of
0+-                    <<":", VName/binary>> ->
0+-                        case get_var(VName, Bindings, V) of
0+-                            V2 when is_list(V2) ->
0+-                                iolist_to_binary(V2);
0+-                            V2 -> V2
0+-                        end;
0+-                    <<"*">> ->
0+-                        get_var(V, Bindings, V);
0+-                    _ ->
0+-                        V
0+-                end,
0+-                [V1|Acc]
0+-            end, [], Value),
0+-            to_json(Value1);
0+-        _ when is_binary(Value) ->
0+-            Value;
0+-        _ ->
0+-            case Key of
0+-                <<"key">> -> to_json(Value);
0+-                <<"startkey">> -> to_json(Value);
0+-                <<"start_key">> -> to_json(Value);
0+-                <<"endkey">> -> to_json(Value);
0+-                <<"end_key">> -> to_json(Value);
0+-                _ ->
0+-                    lists:flatten(?JSON_ENCODE(Value))
0+-            end
0++replace_var(Key, <<":", Var/binary>> = Value, Bindings) ->
0++    get_var(Var, Bindings, Value);
0++replace_var(_Key, Value, Bindings) when is_binary(Value) ->
0++    Value;
0++replace_var(_Key, Value, Bindings) when is_list(Value) ->
0++    lists:foldl(fun
0++                (<<":", Var/binary>>=Value1, Acc) ->
0++                    [get_var(Var, Bindings, Value1)|Acc];
0++                (Value1, Acc) ->
0++                    [Value1|Acc]
0++            end, [], Value);
0++replace_var(Key, Value, _Bindings) ->
0++    Value.
0++                   
0++maybe_json(Key, Value) ->
0++    case lists:member(Key, [<<"key">>, <<"startkey">>, <<"start_key">>,
0++                <<"endkey">>, <<"end_key">>]) of
0++        true ->
0++            ?JSON_ENCODE(Value);
0++        false ->
0++            Value
0+     end.
0+ 
0+-
0+ get_var(VarName, Props, Default) ->
0+     VarName1 = to_binding(VarName),
0+     couch_util:get_value(VarName1, Props, Default).
0+@@ -309,7 +295,7 @@ make_new_path([?MATCH_ALL|_Rest], _Bindings, Remaining, Acc) ->
0+ make_new_path([{bind, P}|Rest], Bindings, Remaining, Acc) ->
0+     P2 = case couch_util:get_value({bind, P}, Bindings) of
0+         undefined -> << "undefined">>;
0+-        P1 -> P1
0++        P1 -> to_json(P1)
0+     end,
0+     make_new_path(Rest, Bindings, Remaining, [P2|Acc]);
0+ make_new_path([P|Rest], Bindings, Remaining, Acc) ->
0+@@ -437,21 +423,25 @@ path_to_list([P|R], Acc, DotDotCount) ->
0+     end,
0+     path_to_list(R, [P1|Acc], DotDotCount).
0+ 
0+-encode_query(Props) ->
0+-    Props1 = lists:foldl(fun ({{bind, K}, V}, Acc) ->
0+-        case K of
0+-            <<"*">> -> Acc;
0+-            _ ->
0+-                V1 = case is_list(V) orelse is_binary(V) of
0+-                    true -> V;
0+-                    false ->
0+-                        % probably it's a number
0+-                        quote_plus(V)
0+-                end,
0+-                [{K, V1} | Acc]
0+-        end
0+-    end, [], Props),
0+-    lists:flatten(mochiweb_util:urlencode(Props1)).
0++maybe_encode_bindings([]) ->
0++    [];
0++maybe_encode_bindings(Props) ->
0++    lists:foldl(fun
0++            ({{bind, <<"*">>}, V}, Acc) ->
0++                Acc;
0++            ({{bind, K}, V}, Acc) ->
0++                V1 = iolist_to_binary(maybe_json(K, V)),
0++                [{K, V1}|Acc]
0++        end, [], Props).
0++               
0++decode_query_value({K,V}) ->
0++    case lists:member(K, ["key", "startkey", "start_key",
0++                "endkey", "end_key"]) of
0++        true ->
0++            {to_binding(K), ?JSON_DECODE(V)};
0++        false ->
0++            {to_binding(K), ?l2b(V)}
0++    end.
0+ 
0+ to_binding({bind, V}) ->
0+     {bind, V};
...
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
--- Revision None
+++ Revision 333063613038
@@ -0,0 +1,162 @@
+diff --git a/src/couchdb/couch_httpd_rewrite.erl b/src/couchdb/couch_httpd_rewrite.erl
+index 6324631..ce44fdd 100644
+--- a/src/couchdb/couch_httpd_rewrite.erl
++++ b/src/couchdb/couch_httpd_rewrite.erl
+@@ -126,8 +126,7 @@ handle_rewrite_req(#httpd{
+     % we are in a design handler
+     DesignId = <<"_design/", DesignName/binary>>,
+     Prefix = <<"/", DbName/binary, "/", DesignId/binary>>,
+-    QueryList = couch_httpd:qs(Req),
+-    QueryList1 = [{to_binding(K), V} || {K, V} <- QueryList],
++    QueryList = lists:map(fun decode_query_value/1, couch_httpd:qs(Req)),
+ 
+     #doc{body={Props}} = DDoc,
+ 
+@@ -145,7 +144,7 @@ handle_rewrite_req(#httpd{
+ 
+             %% get raw path by matching url to a rule.
+             RawPath = case try_bind_path(DispatchList, couch_util:to_binary(Method), PathParts,
+-                                    QueryList1) of
++                                    QueryList) of
+                 no_dispatch_path ->
+                     throw(not_found);
+                 {NewPathParts, Bindings} ->
+@@ -153,13 +152,15 @@ handle_rewrite_req(#httpd{
+ 
+                     % build new path, reencode query args, eventually convert
+                     % them to json
+-                    Path = lists:append(
+-                        string:join(Parts, [?SEPARATOR]),
+-                        case Bindings of
+-                            [] -> [];
+-                            _ -> [$?, encode_query(Bindings)]
+-                        end),
+-                    
++                    Bindings1 = maybe_encode_bindings(Bindings),
++                    ?LOG_INFO("bindings1 ~p~n", [Bindings1]),
++                    Path = binary_to_list(
++                        iolist_to_binary([
++                                string:join(Parts, [?SEPARATOR]),
++                                [["?", mochiweb_util:urlencode(Bindings1)] 
++                                    || Bindings1 =/= [] ]
++                            ])),
++
+                     % if path is relative detect it and rewrite path
+                     case mochiweb_util:safe_relative_path(Path) of
+                         undefined ->
+@@ -253,44 +254,29 @@ make_query_list([{Key, Value}|Rest], Bindings, Acc) when is_list(Value) ->
+ make_query_list([{Key, Value}|Rest], Bindings, Acc) ->
+     make_query_list(Rest, Bindings, [{to_binding(Key), Value}|Acc]).
+ 
+-replace_var(Key, Value, Bindings) ->
+-    case Value of
+-        <<":", Var/binary>> ->
+-            get_var(Var, Bindings, Value);
+-        <<"*">> ->
+-            get_var(Value, Bindings, Value);
+-        _ when is_list(Value) ->
+-            Value1 = lists:foldr(fun(V, Acc) ->
+-                V1 = case V of
+-                    <<":", VName/binary>> ->
+-                        case get_var(VName, Bindings, V) of
+-                            V2 when is_list(V2) ->
+-                                iolist_to_binary(V2);
+-                            V2 -> V2
+-                        end;
+-                    <<"*">> ->
+-                        get_var(V, Bindings, V);
+-                    _ ->
+-                        V
+-                end,
+-                [V1|Acc]
+-            end, [], Value),
+-            to_json(Value1);
+-        _ when is_binary(Value) ->
+-            Value;
+-        _ ->
+-            case Key of
+-                <<"key">> -> to_json(Value);
+-                <<"startkey">> -> to_json(Value);
+-                <<"start_key">> -> to_json(Value);
+-                <<"endkey">> -> to_json(Value);
+-                <<"end_key">> -> to_json(Value);
+-                _ ->
+-                    lists:flatten(?JSON_ENCODE(Value))
+-            end
++replace_var(Key, <<":", Var/binary>> = Value, Bindings) ->
++    get_var(Var, Bindings, Value);
++replace_var(_Key, Value, Bindings) when is_binary(Value) ->
++    Value;
++replace_var(_Key, Value, Bindings) when is_list(Value) ->
++    lists:foldl(fun
++                (<<":", Var/binary>>=Value1, Acc) ->
++                    [get_var(Var, Bindings, Value1)|Acc];
++                (Value1, Acc) ->
++                    [Value1|Acc]
++            end, [], Value);
++replace_var(Key, Value, _Bindings) ->
++    Value.
++                    
++maybe_json(Key, Value) ->
++    case lists:member(Key, [<<"key">>, <<"startkey">>, <<"start_key">>,
++                <<"endkey">>, <<"end_key">>]) of
++        true ->
++            ?JSON_ENCODE(Value);
++        false ->
++            Value
+     end.
+ 
+-
+ get_var(VarName, Props, Default) ->
+     VarName1 = to_binding(VarName),
+     couch_util:get_value(VarName1, Props, Default).
+@@ -309,7 +295,7 @@ make_new_path([?MATCH_ALL|_Rest], _Bindings, Remaining, Acc) ->
+ make_new_path([{bind, P}|Rest], Bindings, Remaining, Acc) ->
+     P2 = case couch_util:get_value({bind, P}, Bindings) of
+         undefined -> << "undefined">>;
+-        P1 -> P1
++        P1 -> to_json(P1)
+     end,
+     make_new_path(Rest, Bindings, Remaining, [P2|Acc]);
+ make_new_path([P|Rest], Bindings, Remaining, Acc) ->
+@@ -437,21 +423,25 @@ path_to_list([P|R], Acc, DotDotCount) ->
+     end,
+     path_to_list(R, [P1|Acc], DotDotCount).
+ 
+-encode_query(Props) -> 
+-    Props1 = lists:foldl(fun ({{bind, K}, V}, Acc) ->
+-        case K of
+-            <<"*">> -> Acc;
+-            _ ->
+-                V1 = case is_list(V) orelse is_binary(V) of
+-                    true -> V;
+-                    false ->
+-                        % probably it's a number
+-                        quote_plus(V)
+-                end,
+-                [{K, V1} | Acc]
+-        end
+-    end, [], Props),
+-    lists:flatten(mochiweb_util:urlencode(Props1)).
++maybe_encode_bindings([]) ->
++    [];
++maybe_encode_bindings(Props) -> 
++    lists:foldl(fun 
++            ({{bind, <<"*">>}, V}, Acc) ->
++                Acc;
++            ({{bind, K}, V}, Acc) ->
++                V1 = iolist_to_binary(maybe_json(K, V)),
++                [{K, V1}|Acc]
++        end, [], Props).
++                
++decode_query_value({K,V}) ->
++    case lists:member(K, ["key", "startkey", "start_key",
++                "endkey", "end_key"]) of
++        true ->
++            {to_binding(K), ?JSON_DECODE(V)};
++        false ->
++            {to_binding(K), ?l2b(V)}
++    end.
+ 
+ to_binding({bind, V}) ->
+     {bind, V};